Code Review: For Me & You

Steve Grunwell (15.Sep.2018 at 16:30, 25 min)
Talk at Cascadia PHP (English - US)

On the surface, the idea of code review is a no-brainer: why *wouldn't* we want a second set of eyes on our code, especially before deploying to production?

As we peel back the layers, however, we find that the topic of code review is much more nuanced. How detailed should the review be? Who is qualified to perform the review (hint: it's not just senior developers)? Can we afford to take another developer away from their project to review this one? What steps can we take to ensure reviews are constructive, rather than demoralizing?

Attendees will gain deeper insight into some of the arguments for and against systemic, peer code review, as well as pick up some useful tools to make code review a natural part of their teams' workflow.

Quicklink: https://legacy.joind.in/24935

Track(s): Crater Lake

Who are you?

Claim talk

Talk claims have been moved to the new Joind.in site.

Please login to the new site to claim your talk

Want to comment on this talk? Log in or create a new account or comment anonymously

Write a comment

Comments

15.Sep.2018 at 17:13 by Patrick Schwisow (136 comments) via Web2 LIVE

Great talk! Nice work fitting all that info in the short time slot.

16.Sep.2018 at 13:49 by Max Schwanekamp (95 comments) via Web2 LIVE

Great talk, somewhat amazing amount of info for a 25 minute slot. Only reason I give 4 instead of 5 is that Steve's verbal examples seemed to conflict significantly with the content of the slides. In particular, he used a lot of direct "you/you're" examples that were bordering on accusatory ("you're just wrong" or something to that effect). I think Steve was being casual and "real world" but especially in light of the preceding talk (The Monster on the Project) I experienced some cognitive dissonance during Steve's talk.

Code Review: For Me & You

Write a comment

Comments

Sign in

Submit your event